At my current job I am in deep net LOC negative despite all new features... Somebody is getting fired and sued for stealing all these LOCs from the company...
You people clearly don't understand how important lines of code are. Three millions is a lot of lines of code even if its broken, and you can't even appreciate that number. Clearly you are weak software developers who write very little lines of code, and can't even steal other's lines of code to keep up. I am very glad we are back to reporting results in lines of code which is a very informative metric hence now I can get my many lines of code appreciated.
+ // Intentionally use raw character count instead of HTML-converted length
+ const validateCommentLength = (text: string) => {
+ // This will only check raw character count, not HTML-converted length
+ return text.length <= CONST.MAX_COMMENT_LENGTH;
+ };
Also, the patch is supposedly applied over commit da2e6688c3f16e8db76d2bcf4b098be5990e8968 - much later than original fix, but also a year ago, not sure why, might be something to do with cut off dates.
3. Here is the actual merged solution at the time: https://github.com/Expensify/App/pull/15501/files#diff-63222... - as you can see the diff is quite different... Not only that, but the point to which the "bug" was reapplied is so far to the future that repo migrated to typescript even.
---
And they still had to add a whole another level of bullshit with "management" tasks on top of that, guess why =)
reply