Better code reviews for GitHub. It integrates with GitHub to provide a better reviewing and commenting experience for pull requests. Free for open source!
Ah yeah, it only supports Chrome (and Chrome based browsers) and Firefox for now. I've been meaning to add an error message if you use a different browser.
No newsletter yet, but you can follow me on Twitter for now @jameslao.
I can see how the iterations control can be not obvious. I'll add a docs section that explains it. The two columns of radio buttons represent your selection for the left and right side of the diff. You can also click on any iteration to diff it against the base.
I've made a couple notes based on this to help me prioritize next. Thanks for taking the time to provide all this amazing feedback!
I hear you. Crocodile has a couple features that try to address this.
1. More comment states. Comments start as "open". The workflow I had in mind was that once the author addresses it, they would mark it as "resolved". The reviewer can go to the comments view (in the meta section on the left nav) where they can filter to resolved comments. If it looks good, they can mark it as "closed" or "open" again if they want more changes. I have this as a suggested workflow in the docs. [1]
2. The iterations section in the left nav lets you compare any two iterations. You can use this to see what has changed since your last review. Crocodile even indicates which iteration your last review was on to make this easy.
That's actually a use case I've thought about. When review time came around, one of my past managers would compile statistics on everyone's reviews to see how much they've been participating.
Another feature I've thought about is "show me all of person X's reviews and comments across all repos". That would have been super useful when I was on promo panels to go through and see if a promo candidate's review comments were useful, constructive, kind, etc.
Exactly! You bring a great point with promo panels where the difference between the amount of time put into building a promo package and the amount of time the panel spend on it can be considerable (my experience at Twitter).
I think when it comes to per-seat pricing, it's good to remember that engineers don't put the credit card in. The person with the credit card will want to know ROI before investing. The engineers will want to try out first as a group and if their experience is positive (some of it might be subjective) then they'll need to build a case for why the company should pay for your product and that's where analytics can be leveraged for sales.
If you click the "Comments ->" link in the meta section on the left nav of the review, it will take you to my version of the comments panel.
A couple improvements I made:
* You can see the whole discussion. The last time I used CodeFlow it only showed one line of the comment which often wasn't enough for me to remember what it was so in practice I always had to click on every single one to see the whole thing. Not a big deal with CodeFlow since it was so snappy as you mentioned.
* It shows a preview of the code that was commented on to provide context.
Thanks for taking a look! Great to see other CodeFlow fans out there.
Better code reviews for GitHub. It integrates with GitHub to provide a better reviewing and commenting experience for pull requests. Free for open source!