Hacker Newsnew | past | comments | ask | show | jobs | submit | x25519's commentslogin


Wow, I was surprised at the sheer size of the diff. Huge!

Can any of you tell if it includes unit tests? I didn't see any.


Their tests live in a separate repo


That must make working out whether a code change is well tested a whole bunch of fun.




Glad to see the bug is now updated/fixed, but the person you're replying to said they were already using 1.8.3. I guess you're saying their issues were caused by a different bug.



No, new features don't usually get backported to the stable branch.

It will ship with 1.13.9 (mainline) in 6 hours (at the time of writing).

For stable branch, you need to wait until the 1.13 milestone is completed, which according to their roadmap (https://trac.nginx.org/nginx/milestone/1.13) will be completed in 8 weeks.


They did a static analysis and fixed a null pointer dereference here: https://hg.nginx.org/nginx/rev/8b0553239592


They might want to consider using clang nullability annotations (_Nullable etc) when compiling on clang. Can use a macro so it becomes a noop when the compiler does not support it. The static analyser would then get a lot of more information to work with, and it also serves as a kind of documentation.


Is there any way to disable alphabetical sorting of network monitor's HTTP response headers?

From 53.x (IIRC) to 56.x, Firefox keeps the original order set by the server (like the one you see in the raw headers section or `curl -I`), and I like it that way.


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: