Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

`concat` doesn't happen in place, it builds a new array:

    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/concat


True, but does not mean the type of the array that should be built should be of different types. I think the sane definition by Typescript is that it should be of the same type: that's why it's an instance method and not a static one. If this was a static method (Array.concat(a, b)), I would agree that would be a good assumption, that the type of the resulting array should be union of the types of the arguments.


Interesting. Then that should be a fixable bug in TS' lib files then.


There's an issue mentioning it with a PR Welcome sign up: https://github.com/Microsoft/TypeScript/issues/27545


Ah, and there is at least one PR specifically for it: https://github.com/Microsoft/TypeScript/pull/25716




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: