The detailed specifics of this would be interesting to know. If I accidentally flip iCloud photos on and then turn it off within a few minutes, would that give the system license to scan all my photos once? What if my phone is in airplane mode and I turn iCloud photos on? Will the system scan photos and create vouchers offline for later upload?
Edit: On a related note, will turning on iCloud photos now come with a modal prompt and privacy warning so you're fully informed and can't do it "by accident"? Pardon my ignorance if this happens already. I've never turned mine on and am not about to start.
Turning your own device against you is better? There is no way that is better for you as a user. It's great for governments and police forces but it doesn't do anything for you as a user but spy on you without getting a warrant.
Often, despite all its disadvantages, on-device scanning would at least let know see what was being scanned for.
But Apple have circumvented that with NeuralHash. There's no way for the user to verify that only CSAM is being detected - which could be partially accomplished by having iOS only accept hashes signed by multiple independent child protection organisations (with some outside of FVEY).