Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

It fails to build for me. Got a bunch of warnings being treated as errors.

gcc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Wunused-function -Wunused-variable -Wunused-value -Werror -g -march=native -Ofast -fomit-frame-pointer -fstack-protector -D_FORTIFY_SOURCE=2 -flto -fwhole-program -fuse-linker-plugin -I src/core -I src/event -I src/event/modules -I src/os/unix -I objs -I src/http -I src/http/modules \ -o objs/src/http/ngx_http_spdy.o \ src/http/ngx_http_spdy.c

src/http/ngx_http_spdy.c: In function ‘ngx_http_init_spdy’:

src/http/ngx_http_spdy.c:261:34: error: variable ‘rc’ set but not used [-Werror=unused-but-set-variable]

src/http/ngx_http_spdy.c: In function ‘ngx_http_spdy_process_ping’:

src/http/ngx_http_spdy.c:1512:35: error: variable ‘c’ set but not used [-Werror=unused-but-set-variable]

src/http/ngx_http_spdy.c: In function ‘ngx_http_spdy_send_rst_stream’:

src/http/ngx_http_spdy.c:2552:35: error: variable ‘c’ set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors

I would point out that the -Werror is set by the vanilla version of nginx and not a flag that I passed in.



Thanks, fixed. =) Try again: http://nginx.org/patches/spdy/ patch.spdy-36.txt or later revision.


LOL.

Thanks for the quick turnaround. I got distracted with something else right after I posted this and didn't expect such a quick update.

In any case, -36 built just fine and I have verified that I now have SPDY on the server.

FWIW, the format of using

listen 443 spdy; ssl on;

works just fine too.


Warnings are compiler version dependent (and even optimization level dependent, surprisingly). It looks like that one was introduced by gcc 4.6, so perhaps the author of the patch was using a different version.

Chrome builds with -Werror on by default but, because of the above reason, recommends any person attempting to build it to turn it off (and provides a flag to do as much).




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: