I have a ~2009 MacBook. It has a swappable battery (replaced once, dead again), and it was overall easily upgradable : it received a 4GB RAM stick to replace its original 2GB (unfortunately it can't manage more than 3.5GB), an SSD to replace its hard drive, and a new DVD drive as its superdrive failed. However its core2 Duo is really too slow for the modern web (either running MacOS or Linux), it takes almost a full minute to open a youtube link. I should probably downgrade to 32 bits Linux to get back some speed, but it won't become exactly snappy anyway :)
It's a MacBook 5,1, not a MacBook pro. Its firmware only sees 3.5GB out of the 4GB installed, apparently it requires a BootROM upgrade to support more.