"@isaacs may have his commit bit but that does not mean he is at liberty to land patches at will. All patches have to be signed off by either me or Bert. Isaac, consider yourself chided."
Why I rejected the pull request. Us maintainers tend to reject tiny doc changes because they're often more trouble than they're worth. You have to collect and check the CLA, it makes git blame less effective, etc.
That's why the usual approach to such pull requests is 'no, unless' - in this case the 'unless' should probably have applied. To me as a non-native speaker, the difference between 'him' and 'them' seems academic but hey, if it gets us scores of female contributors, who am I to object?
Why I reverted the commit. In hindsight, I should have given Isaac the benefit of the doubt because I don't doubt that he acted with the best of intentions. On the other hand, if another committer jumped the line like that, I would have done the same thing. We have procedures in place and no one is exempt from them.
To the people that felt it necessary to call me a misogynist: I volunteer in a mentorship program that gets young people - especially young women - involved in technology. How many of you go out and actively try to increase the number of women in the field?
I'm probably going to step back from libuv and node.js core development. I do it more out a sense of duty than anything else. If this is what I have to deal with, then I'd just as rather do something else. Hope that clears things up. Thanks."
"Sorry, not interested in trivial changes like that."
- https://github.com/joyent/libuv/pull/1015#issuecomment-29538...
"@isaacs may have his commit bit but that does not mean he is at liberty to land patches at will. All patches have to be signed off by either me or Bert. Isaac, consider yourself chided."
- https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482d...
"Hi all, let me try to clear up a few things.
Why I rejected the pull request. Us maintainers tend to reject tiny doc changes because they're often more trouble than they're worth. You have to collect and check the CLA, it makes git blame less effective, etc.
That's why the usual approach to such pull requests is 'no, unless' - in this case the 'unless' should probably have applied. To me as a non-native speaker, the difference between 'him' and 'them' seems academic but hey, if it gets us scores of female contributors, who am I to object?
Why I reverted the commit. In hindsight, I should have given Isaac the benefit of the doubt because I don't doubt that he acted with the best of intentions. On the other hand, if another committer jumped the line like that, I would have done the same thing. We have procedures in place and no one is exempt from them.
To the people that felt it necessary to call me a misogynist: I volunteer in a mentorship program that gets young people - especially young women - involved in technology. How many of you go out and actively try to increase the number of women in the field?
I'm probably going to step back from libuv and node.js core development. I do it more out a sense of duty than anything else. If this is what I have to deal with, then I'd just as rather do something else. Hope that clears things up. Thanks."
- https://github.com/joyent/libuv/pull/1015#issuecomment-29568...